refactor(hugrv2)!: Rename Terms to clarify (runtime) Types from static parameter Kinds#3019
Open
acl-cqc wants to merge 7 commits into
Open
refactor(hugrv2)!: Rename Terms to clarify (runtime) Types from static parameter Kinds#3019acl-cqc wants to merge 7 commits into
acl-cqc wants to merge 7 commits into
Conversation
acl-cqc
changed the title
acl-cqc
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3019 +/- ##
==========================================
- Coverage 81.09% 81.09% -0.01%
==========================================
Files 241 241
Lines 45054 45050 -4
Branches 38822 38818 -4
==========================================
- Hits 36536 36532 -4
Misses 6542 6542
Partials 1976 1976
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
Merging this PR will not alter performance
Comparing 
Footnotes
|
acl-cqc
force-pushed
the
acl/boundless_type
branch
from
2dec804 to
b45e61f
Compare
Collaborator
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary |
acl-cqc
force-pushed
the
acl/rename_type_kind
branch
from
45f1367 to
6ea5e65
Compare
cqc-alec
approved these changes
May 5, 2026
Collaborator
cqc-alec
left a comment
cqc-alec
left a comment
There was a problem hiding this comment.
Thanks!
Should we also change TermTypeError::TypeMismatch { term, type_} to TermTypeError::KindMismatch {value, kind}? I guess we should??
Yes I guess we should do that as well.
Contributor
Author
I am gonna do that as a followup because I realize there is also TermTypeError (=> TermKindError?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Note: this will textually conflict with #3022, will have to merge whichever is approved second but I think should b straightforward.]
Using
Typeto mean a static parameter (that accepts a static Term argument) is confusing; instead keep Type as meaning a type of runtime valuesTerm::RuntimeTypebecomesTerm::TypeKindTerm::XXXTypebecomesTerm:::XXXKind(e.g.StringType->StringKind,ListType->ListKind)Term::RuntimeXXXbecomesTerm::XXXType(e.g.Term::RuntimeExtension->Term::ExtensionType)check_term_type->check_term_kindTermTypeError -> TermKindError to follow in another PR.
BREAKING CHANGE: many renames of variants of Term; ...Types are now Kinds, Runtime... are now Types. Also check_term_type is now check_term_kind